forked from jgm/lunamark
-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Define
parsers.punctuation
in a streaming fashion
Since #416, we have first read all Unicode punctuation characters to a table `punctuation`, then defined `parsers.punctuation` using the table `punctuation`, and then we deleted the table `punctuation`. Since #416, we have also been experiencing steady out-of-memory issues with our capybara runner, as discussed with @TeXhackse earlier today. I have disabled capybara, since it's been having intermittent out-of-memory issues ever since Markdown 3.0.0 and its speed has also lately been an issue. Nevertheless, this indicates a potential cost of the current approach, which may eventually impact our users as well. This PR removes the table `punctuation` directly from the file `UnicodeData.txt` without any intermediate data structure. This should alleviate any memory issues caused by #416.
- Loading branch information
Showing
1 changed file
with
31 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters