Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPUSwift] release build workaround for rdar://140993460 #37774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nmahendru
Copy link
Contributor

@nmahendru nmahendru commented Dec 11, 2024

@nmahendru nmahendru self-assigned this Dec 11, 2024
@nmahendru nmahendru added the WebGPU For bugs in WebGPU label Dec 11, 2024
https://bugs.webkit.org/show_bug.cgi?id=284462
rdar://141282776

Reviewed by NOBODY (OOPS!).

Reordering inheritance list for CommandEncoder helps the release build to work until rdar://140993460 is resolved.

* Source/WebGPU/WebGPU/CommandEncoder.h:
@nmahendru nmahendru force-pushed the eng/WebGPUSwift-release-build-workaround-for-rdar-140993460 branch from 3f9ea40 to 184df15 Compare December 11, 2024 15:17
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

Let's leave a comment behind with a Radar link, so mechanical refactoring doesn't revert this change by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants