Skip anchor-download-redirect-cross-origin.html on WK1 #37513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmahendru
added
the
New Bugs
|
EWS run on previous version of this PR (hash 3919fee) |
nmahendru
force-pushed
the
eng/New-Test-284937-main-Sequoia-wk1-http-tests-download-anchor-download-redirect-cross-origin-html-is-a-consistent-failure
branch
from
3919fee to
ddaefbd
Compare
|
EWS run on previous version of this PR (hash ddaefbd) |
nmahendru
changed the title
nmahendru
force-pushed
the
eng/New-Test-284937-main-Sequoia-wk1-http-tests-download-anchor-download-redirect-cross-origin-html-is-a-consistent-failure
branch
from
ddaefbd to
9cb0f94
Compare
|
EWS run on current version of this PR (hash 9cb0f94)
|
🛠 mac-safer-cpp
achristensen07
approved these changes
Dec 6, 2024
nmahendru
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=284068 rdar://140939708 Reviewed by Alex Christensen. The original fix is only intended for WK2 and there is not plan to add a similar fix for WK1. The same applies to the test added to validate that fix. Missing to add [ Skip ] for WK1 originally was an oversight. My bad. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/287418@main
webkit-commit-queue
force-pushed
the
eng/New-Test-284937-main-Sequoia-wk1-http-tests-download-anchor-download-redirect-cross-origin-html-is-a-consistent-failure
branch
from
9cb0f94 to
a3cc9c5
Compare
|
Committed 287418@main (a3cc9c5): https://commits.webkit.org/287418@main Reviewed commits have been landed. Closing PR #37513 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a3cc9c5
9cb0f94
🛠 ios🛠 mac🛠 wpe🛠 win🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🛠 vision🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 tv🛠 tv-sim🛠 watch🛠 watch-sim