Reconsider if closing pre-opens are prohibited #50
Comments
See WebAssembly/wasi-testsuite#50 Signed-off-by: Adrian Cole <[email protected]>
See WebAssembly/wasi-testsuite#50 Signed-off-by: Adrian Cole <[email protected]>
Add documentation mentioning stdin, stdout, and stderr file descriptors, and also preopen file descriptors, and mention that preopen file descriptors can be closed. Allowing preopen file descriptors to be closed is a change from how Wasmtime historically worked, but I think it's more clear now that it's ok to let preopens be closed. We'll change Wasmtime accordingly. This addresses WebAssembly/wasi-testsuite#50.
|
Your reasoning makes sense to me. We should change the spec to allow preopens to be closed. I've now filed WebAssembly/WASI#522 to propose this. |
* Add documentation about starting file descriptors in Preview1. Add documentation mentioning stdin, stdout, and stderr file descriptors, and also preopen file descriptors, and mention that preopen file descriptors can be closed. Allowing preopen file descriptors to be closed is a change from how Wasmtime historically worked, but I think it's more clear now that it's ok to let preopens be closed. We'll change Wasmtime accordingly. This addresses WebAssembly/wasi-testsuite#50. * Say "stream" instead of "file-like".
|
Suppose preopens are 3, 4 and 5 and 4 is closed and a new scan of preopens is done then 5 will not be found. |
1 similar comment
|
Suppose preopens are 3, 4 and 5 and 4 is closed and a new scan of preopens is done then 5 will not be found. |
Interesting, I had noticed that pre-open scans tended to be a one-shot deal (at program init), can you link me something that does this routinely? Something that does could help make a test to ensure they continue to work. |
|
I just want clarity. It is a pity that obtaining predirs is not like args_get and environment_get then the fd's need not be 3,4,... |
@loganek recently added a rust
close_preopentest , which ensures user code can't close a.. pre-open. In some ways stdio are like pre-opens, as in wazero, we had exactly the opposite request by @vyskocilm which is to ensure stdio can be closed. I'd like to understand how to rationalize both at the same time, even if wazero tentatively blocks closing strict pre-opens (fd=3) while still allowing code to close stdio (implicit pre-opens)See tetratelabs/wazero#953
The text was updated successfully, but these errors were encountered: