[NFC] Improve ClusterFuzz testing #7157
Open
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Dec 18, 2024
| # We should not see any mention of a wasm-opt error that caused a | ||
| # retry. On production ClusterFuzz this is not an error, but we do want | ||
| # to know about such issues, as they may be real bugs in wasm-opt. | ||
| assert 'retry' not in out, out |
There was a problem hiding this comment.
Are asserts not executed on production ClusterFuzz infra?
There was a problem hiding this comment.
They are, but fuzz_opt.py is not run there, instead we run clusterfuzz/run.py. fuzz_opt is only for our local testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-optissue, locally (in production, wedon't want to error on ClusterFuzz).
test_run_pyto the helpergenerate_testcases(so that the asserts happen in all callers).