Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Czech language support #259

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Czech language support #259

merged 2 commits into from
Aug 20, 2020

Conversation

martingeorgiu
Copy link
Contributor

No description provided.

Boris-Em
Boris-Em suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@Boris-Em Boris-Em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @killalad!
I have one question for you.

.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Aug 14, 2020

Fails
🚫

WeScanTests/CIRectangleDetectorTests.swift#L55 - WeScanTests.CIRectangleDetectorTests: testCorrectlyDetectsAndReturnsQuadilateral
failed - Snapshot comparison failed: Optional(Error Domain=FBSnapshotTestControllerErrorDomain Code=1 "Unable to load reference image." UserInfo={NSLocalizedFailureReason=Reference image not found. You need to run the test in record mode, NSLocalizedDescription=Unable to load reference image., FBReferenceImageFilePathKey=/Users/vagrant/git/WeScanTests/ReferenceImages_64/WeScanTests.CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral_13_6.png})
Warnings
⚠️ Please provide a summary in the Pull Request description
⚠️ Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the WeScanSampleProject editor. (in target 'WeScanSampleProject' from project 'WeScan')
Messages
📖

View more details on Bitrise
📖 WeScan: Executed 56 tests, with 1 failure (0 unexpected) in 20.068 (20.171) seconds

Generated by 🚫 Danger Swift against d7b65de

AvdLee
AvdLee approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @Boris-Em the tests are not failing due to changes from this PR I think so I would be fine merging this in.

@Boris-Em Boris-Em merged commit 401df1b into WeTransfer:master Aug 20, 2020
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.8.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boris-Em Boris-Em Boris-Em approved these changes

@AvdLee AvdLee AvdLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martingeorgiu @wetransferplatform @AvdLee @Boris-Em