Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check weights match #4649

Merged
merged 3 commits into from
Oct 9, 2023
Merged

test: check weights match #4649

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb3ee41
test: check weights match
bassmang Oct 5, 2023
f22aff2
sort weights for sparse
bassmang Oct 5, 2023
1ed2bf4
lint
bassmang Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/run_tests_model_gen_and_load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,15 @@ def load_model(
weights_dir = working_dir / "test_weights"
weights_dir.mkdir(parents=True, exist_ok=True)
weight_file = str(weights_dir / f"weights_{test_id}.json")

# Load old weights
old_weights = json.load(open(weight_file))

# Sort the weights inside both dictionaries based on 'index'
new_weights["weights"].sort(key=lambda x: x["index"])
old_weights["weights"].sort(key=lambda x: x["index"])

# Assert if both sorted weights are equal
assert new_weights == old_weights
vw.finish()
except Exception as e:
Expand Down
Loading