Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detail field to VAPI event object #274

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

dragonmantank
Copy link
Contributor

Description

Allows the detail field to be properly deserialized and accessed if it's part of an event.

Motivation and Context

This field now appears on some events, so should be made available. Otherwise this will just return null.

How Has This Been Tested?

Unit testing. I was not able to generate the new events using a US number so crafted a webhook response based on the API spec.

Example Output or Screenshots (if appropriate):

// If the webhook is an Event with a detail key:
$event = Factory::createFromRequest($request);
echo $event->getDetail();

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank force-pushed the enhancement/devx-5364-vapi-detail-field branch from c51b7ff to 2f81d47 Compare February 23, 2021 03:22
@dragonmantank dragonmantank changed the base branch from master to 2.x February 23, 2021 03:38
@hummusonrails
Copy link

Spent time this morning reviewing this, it looks good!

@dragonmantank dragonmantank merged commit 0994517 into 2.x Feb 23, 2021
dragonmantank added a commit to Nexmo/nexmo-php that referenced this pull request Mar 1, 2021
@SecondeJK SecondeJK deleted the enhancement/devx-5364-vapi-detail-field branch January 18, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants