Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fixing typo in ServiceType enum #867

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

ajumal-ashraf-dev
Copy link
Contributor

Description

I have corrected the typo in the enum from "voice," to "voice".

Motivation and Context

There was an extra comma in the enum value causing the REST calls to fail and return a 404 error on requesting pricing for "voice"

Testing Details

Tested in a sample project. Does not affect other areas.

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ajumal-ashraf-dev
Copy link
Contributor Author

ajumal-ashraf-dev commented Sep 24, 2023

@dragonmantank @tommorris @cbetta @benfoxall @mheap Please review the change. Thank you.

@manchuck
Copy link
Contributor

Note to me: Double check your macros when building out enums

@codecov-commenter
Copy link

Codecov Report

Merging #867 (517260c) into 3.x (12ec202) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.x     #867   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         121      121           
  Lines        1619     1619           
  Branches      311      311           
=======================================
  Hits         1358     1358           
  Misses        260      260           
  Partials        1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck merged commit 65d4bcf into Vonage:3.x Sep 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants