Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logs from ResourceTestHelper.js #304

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

AlexLakatos
Copy link
Contributor

@AlexLakatos AlexLakatos commented Jun 10, 2020

Remove extraneous console.log from the tests, it's creating chaotic output.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #304 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files          25       25           
  Lines         824      824           
=======================================
  Hits          745      745           
  Misses         79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78807b2...b0b2954. Read the comment docs.

@lornajane lornajane self-requested a review June 10, 2020 17:08
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed does improve the output of the tests

@lornajane lornajane merged commit 39a7f92 into master Jun 10, 2020
@lornajane lornajane deleted the remove-test-logs branch June 10, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants