Handle 204 status code #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @AverageMarcus ! Continuing the discussion from #154 ,agreed with @judy2k that a |
AlexLakatos
suggested changes
Oct 16, 2017
src/HttpClient.js
Outdated
| @@ -123,6 +123,8 @@ class HttpClient { | |||
| headers['retry-after'] = retryAfterMillis; | |||
| } | |||
| error = {body: data.join('')}; | |||
| } else if (status === 204) { | |||
| response = data; | |||
There was a problem hiding this comment.
can we return null here instead please?
test/HttpClient-test.js
Outdated
| @@ -271,6 +271,14 @@ describe('parseResponse', function() { | |||
| expect(callback).was.calledWith({ statusCode: 404, body: { 'error' : 'error' }, headers: headers}, null); | |||
| }); | |||
|
|
|||
| it ('should parse a 204 status code as a JSON object', function() { | |||
There was a problem hiding this comment.
and update the test as well. We shouldn't parse a 204 as JSON
AlexLakatos
approved these changes
Oct 16, 2017
|
LGTM - I've merged it in to master. Thanks @AverageMarcus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a call a 204 response is returned (such as when hanging up an active call). Currently this is seen as an error by the lib but the action does perform correctly but doesn't provide any response body.
(Created again after messing up #154.)