Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added maxVisibleValues option in minimize view #147

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Apr 5, 2024

Resolves: #146

Also added keeping menu opened on option select for multi-variables

@vitPinchuk vitPinchuk requested a review from asimonok April 5, 2024 07:47
@vitPinchuk vitPinchuk self-assigned this Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.82%. Comparing base (482101d) to head (5c69a3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   98.81%   98.82%           
=======================================
  Files          56       56           
  Lines        1186     1188    +2     
  Branches      292      331   +39     
=======================================
+ Hits         1172     1174    +2     
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Apr 5, 2024
@mikhail-vl mikhail-vl added this to the Version 3.0.0 milestone Apr 5, 2024
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@asimonok asimonok requested a review from mikhail-vl April 10, 2024 06:22
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit b1b7456 into main Apr 17, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/maxVisibleValues-minimize-view branch April 17, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maxVisibleValues option in minimize view
4 participants