Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace code parameters with Code Parameters Builder #261

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Replace code parameters with Code Parameters Builder #261

merged 5 commits into from
Mar 6, 2024

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Mar 4, 2024

Resolves #260

@asimonok asimonok requested a review from mikhail-vl March 4, 2024 13:23
@asimonok asimonok self-assigned this Mar 4, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (6a40a05) to head (f6015b3).

❗ Current head f6015b3 differs from pull request most recent head ad42f1a. Consider uploading reports for the commit ad42f1a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   97.36%   97.39%   +0.03%     
==========================================
  Files          33       34       +1     
  Lines         417      423       +6     
  Branches       72       61      -11     
==========================================
+ Hits          406      412       +6     
  Misses         11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Mar 6, 2024
@mikhail-vl mikhail-vl added this to the Version 5.3.0 milestone Mar 6, 2024
mikhail-vl
mikhail-vl approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 267e6a5 into main Mar 6, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/code-parameters-builder branch March 6, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@asimonok asimonok

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 5.3.0
Development

Successfully merging this pull request may close these issues.

Use code parameters builder for custom code
2 participants
@asimonok @mikhail-vl