Ensure consecutive -Wconf:* flags are not ignored
#3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Oct 24, 2024
prolativ
reviewed
Oct 24, 2024
modules/integration/src/test/scala/scala/cli/integration/SipScalaTests.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/SipScalaTests.scala
Show resolved
Hide resolved
modules/options/src/main/scala/scala/build/options/ScalacOpt.scala
Outdated
Show resolved
Hide resolved
Gedochao
force-pushed
the
maintenance/repeating-wconf
branch
from
d40719f to
8e8a056
Compare
tgodzik
approved these changes
Oct 24, 2024
Gedochao
force-pushed
the
maintenance/repeating-wconf
branch
from
0ae9f72 to
d2a2e59
Compare
Gedochao
changed the title
-Wconf:* flags are not ignored
prolativ
approved these changes
Oct 24, 2024
…ves follow the same order
Gedochao
force-pushed
the
maintenance/repeating-wconf
branch
from
d2a2e59 to
9454f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a fix for the issue noted in scala/scala3#21818 (comment)