Feature/asset uploader #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 30, 2014 06:09
renaming the class makes more sense when making a ProviderHolder (to do similar job as the PathHolder but for providers and not for paths). So I can have a provider class to be extended by each service provider.
with interface and registered in the service provider also injected in the Cdn class
split the push function into small functions and validate if the config file exist
for the last time I will change this file name, I think this is the best way to describe it
rename the get and set of AllowedPaths to Assets in the AssetsHolder class. rename getAssets to findAssets in the cdn class. reorder the 'use' in the finder class
fix the files reading test and add exception to the cdn class and remove useless function from the cdn class
make some change to the config file and remove ProviderHolder and add ProviderFactory and add more exceptions classes
…t based on the default configuration
fill the provider abstract class
modify the finder read function to return file objects instead of string of paths
and initialize an object (inside providerFactory) from it using the App make to resolve dependency
add threshold option, update the configuration to take ACL permission for amazon
and compoes the url in the provider factory it will make it easy to to generate assets urls from the asset helper function
…ion scope in the provider factory
remove the reading of the configurations from the CdnFacade class to the Factory (to be only place responsible on reading the config file and checking nothing is missing) and calling the factory from the CdnFacade (same like in the cdn manager) to create and return the corresponding provider class
and add the url generator function to the interface and updating some comments on the way
this class is to hold the shared function between the cdn class and the Cdnfacade class
(it never had a default if not exist)
added 15 commits
September 3, 2014 21:28
Mulkave
added a commit
that referenced
this pull request
Sep 4, 2014
Asset Uploader and URL Generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files can be uploaded to the CDN. using the "php artisan cdn:push"
fill the config file and run the command.