Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP]cfg: bump pylint-odoo to v8.0.21 #126

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

antonag32
Copy link
Contributor

This adds the new pylint-odoo deprecated-odoo-model-method check.

@antonag32 antonag32 force-pushed the bump-pylint-odoo-anton branch from b336c92 to 1e33745 Compare October 2, 2023 20:03
This adds the new pylint-odoo `deprecated-odoo-model-method` check.
@antonag32 antonag32 force-pushed the bump-pylint-odoo-anton branch from 1e33745 to 7fe3835 Compare October 2, 2023 21:29
@moylop260
Copy link
Collaborator

LGTM

(Let me know when "draft" is removed)

@antonag32 antonag32 changed the title Draft: [IMP]cfg: bump pylint-odoo to v8.0.21 [IMP]cfg: bump pylint-odoo to v8.0.21 Oct 2, 2023
@antonag32
Copy link
Contributor Author

@moylop260 I removed the draft, I was just waiting to test it on a project, I tested it on sbd and it looked good.

@moylop260 moylop260 merged commit e7ae0d0 into Vauxoo:main Oct 2, 2023
19 checks passed
@moylop260 moylop260 deleted the bump-pylint-odoo-anton branch October 2, 2023 23:39
@moylop260
Copy link
Collaborator

moylop260 commented Oct 2, 2023

@antonag32

Even if it was released the docker image was not built correctly:

@ruiztulio

Could you help us here, please?

@ruiztulio
Copy link

ruiztulio commented Oct 9, 2023

@moylop260 This seems to be a problem with cargo and lingit2, the issue was reported here.

Seems to be solved as for the author comment, so I have no idea what's going on, I will need more tome to check which dependency is not updated.

The error was originated by a change in a Twine dependency, they changed to nh3 which depends on amonia and is the one raising the error.

I managed to replicate it:

image

Now I need to solve it (WIP).

Edit:

Internal issue

@moylop260
Copy link
Collaborator

moylop260 commented Oct 9, 2023

@ruiztulio

What about freezing the twine version meanwhile it is fixed?

Forget it

I just understand it is a dependency from twine but not twine itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants