Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): map network interface plan to state using indices and addresses #667

Merged
merged 13 commits into from
Nov 13, 2024
Merged

fix(server): map network interface plan to state using indices and addresses #667

merged 13 commits into from
Nov 13, 2024

Conversation

kangasta
Copy link
Contributor

@kangasta kangasta commented Oct 21, 2024 •
edited
Loading

  • Fix IP handling for private and utility networks
  • Helper to avoid duplicate code in buildNetworkOpts and addressesFromResourceData
  • Update CHANGELOG
  • Update network_interface description to describe new logic
  • Check re-order logic
  • Check why TestUpcloudServer_networkInterface tries to delete interface with index 0.

@kangasta kangasta force-pushed the fix/server-nic-index branch from 31980c2 to af8c0a8 Compare October 28, 2024 17:35
@kangasta kangasta force-pushed the fix/server-nic-index branch from af8c0a8 to b5c9b90 Compare October 31, 2024 19:02
@kangasta kangasta force-pushed the fix/server-nic-index branch from a4395db to e70dd80 Compare November 7, 2024 19:02
@kangasta kangasta marked this pull request as ready for review November 8, 2024 09:23
@kangasta kangasta requested a review from a team as a code owner November 8, 2024 09:23
villevsv-upcloud and others added 3 commits November 11, 2024 15:12
@villevsv-upcloud @kangasta
feat(server): state upgrader for index (#681)
69e7301 
* feat(server): state upgrader for index

* chore: Update internal/service/server/server.go

Co-authored-by: Toni Kangas <[email protected]>

---------

Co-authored-by: Toni Kangas <[email protected]>
@kangasta
chore: merge origin/main into fix/server-nic-index
b718827
@kangasta
fix: do not redefine built-in new
916b0a9
@kangasta kangasta force-pushed the fix/server-nic-index branch from 26864cd to 916b0a9 Compare November 12, 2024 08:20
@kangasta kangasta merged commit d6cffa9 into main Nov 13, 2024
4 of 5 checks passed
@kangasta kangasta deleted the fix/server-nic-index branch November 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villevsv-upcloud villevsv-upcloud villevsv-upcloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangasta @villevsv-upcloud