-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): static routes support #404
Conversation
3b11754
to
5d49788
Compare
@@ -10,6 +10,10 @@ variable "zone" { | |||
|
|||
resource "upcloud_router" "this" { | |||
name = "${var.prefix}router" | |||
|
|||
lifecycle { | |||
ignore_changes = [static_route] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the gateway automatically set static_routes
to the router? Could we somehow handle that automatic route so that end-user does not have to use lifecycle.ignore_changes
🤔 Or is it something we could instruct user to do themselves, like the router creation with Kubernetes clusters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment to the documentation for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The static routes automatically set by the gateway seem to be in link-local address space (169.254.0.0/16
). Thus, they should not collide with values expected from user. Maybe some sort special value would work here, but that would require more investigating/testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good to merge this like this to unblock the release and then try to add fix or workaround for this later 🤔 I was also trying to think of some nice way of fixing this, but no good ideas this far.
Co-authored-by: villevsv-upcloud <[email protected]>
No description provided.