refactor(nft-fractionalization): use asset-ops #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrshiposha
force-pushed
the
feature/pallet-frac-use-asset-ops
branch
4 times, most recently
from
21c2b30 to
57775bc
Compare
mrshiposha
force-pushed
the
feature/pallet-nfts-impl-asset-ops
branch
from
fe88c93 to
20cd25d
Compare
mrshiposha
force-pushed
the
feature/pallet-frac-use-asset-ops
branch
from
57775bc to
3f12aeb
Compare
mrshiposha
force-pushed
the
feature/pallet-frac-use-asset-ops
branch
from
3f12aeb to
ddd8d2a
Compare
mrshiposha
changed the base branch from
feature/pallet-nfts-impl-asset-ops
to
xcm-nft-dev-env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the usage of new NFT traits to pallet-nft-fractionalization.
Thanks to the new traits, the pallet can now interact with collection-less NFTs in addition to the in-collection ones (or even fractionalize whole collections if wanted).
Also, since both pallet-uniques and pallet-nfts implement the new traits, they can both be integrated with fractionalization
(Note: for pallet-uniques
UpdateMetadata<CanTransfer>is needed, though).Another change is that fractionalized assets
NameandSymbolare now NFT ID-dependent, and this is fully configurable by the Runtime (in contrast to the old implementation where theNamewas actually the "name prefix").This also means that the format of the NFT ID in the fractionalized name is now configurable instead of hard-coded.
Note: the implementation of the new traits for pallet-nfts can be found on this branch: https://github.com/UniqueNetwork/polkadot-sdk/tree/xcm-nft-dev-env
TODO Benchmarks were broken even before the changes. They need to be fixed.
TODO This pallet doesn't support multiple instances in the Runtime. I believe it should be fixed as well.