Updates for using mssql server (not to be merged with fixing check of… #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which sql driver is being used).
|
Fixed, queries working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing:
One should find a way how to check which driver is used and if ms sql, run the proper version of the query - in DbExecutionServerImpl.java. So it seems that the issue is just with the query in DbExecutionServerImpl.java, otherwise fixed.
From Paul: From what I remember the main problem I had was a small diff in the SQL usage (LIMIT vs TOP) and the position of that definition in the SQL query. I couldn't find an easy way to get the persistent level to make a distinction based on the JDBC driver (I didn't know enough on that level to convert it into a proper fix). Other than that it did work though.