Frontend - backend communication unification in single/cluster backend mode #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode (via database) Now not frontend nor backend needs to know if backend runs in single / cluster mode
eea03
added
status: in progress
severity: enhancement
priority: High
status: ready for test
and removed
status: in progress
labels
| if (this.clusterMode) { | ||
| this.backendID = this.appConfig.getString(ConfigProperty.BACKEND_ID); | ||
| } | ||
| this.backendID = this.appConfig.getString(ConfigProperty.BACKEND_ID); |
There was a problem hiding this comment.
Note for tomas-knap: what happens if the config.properties BACKEND_ID is missing?
There was a problem hiding this comment.
Backend process will not even start without this property and error messages is shown in logs:
Invocation of init method failed; nested exception is cz.cuni.mff.xrg.odcs.commons.app.conf.MissingConfigPropertyException: Config is missing property: backend.id.
This is the standard behavior for mandatory parameters after error handling in backend was fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #514
Now frontend always checks if backend is online via database, not RMI.
Furthermore, frontend nor backend does not need to know if backend runs in cluster mode.