SSO support in UV

[skrchnavy]

Improved security/permission model in UV to support SSO.
Implementation shall be backward compatible, so if UV not configured to use SSO, it uses users stored in DB and also 2 roles are supported.

[tomas-knap]

@peterklimo, please adjust also mysql DB scripts based on your changes (table Permission etc). I cannot see such adjustment in the commits, although there is an adjustment for postgres: db/postgresql/data.sql

@peterklimo I miss some "cas_enabled=yes/no" config option in the configuration file. What is the logic which decides whether CAS will be used or not? It tries to use CAS configuration from config.properties and if it fails (CAS server cannot be contacted), non-CAS authentication is used? Or is there somewhere a special flag which directly says which type of authentication is supported (which is more safe - if CAS fails, error is reported and non-CAS authentication is not accepted)?

[tomas-knap]

@peterklimo Please answer my question above. For example, I still do not see updated db scripts for mysql. I cannot accept this pull request without updated scripts for mysql as well

[tomas-knap]

The only pending issues for the release:

Merge develop to feature/sso_fixes
Update script for mysql.

[tomas-knap]

@peterklimo Please let me know when mysql update script is ready (we were discussing Sunday morning). Cannot prepare release branch without first merging feature/sso_fixes to develop (feature branches should not be merged to release branches directly) . And I cannot merge feature/sso_fixes to develop without the update script.

[tomas-knap]

@peterklimo One more issue, the following code (if (!defaultOrganization.isEmpty()) ) from PasswordAuthenticationProvider.java throws NullPointerException if ownership.type is set to user (in config properties) and organization is not specified in config.properties:

  String defaultOrganization = null;
        if (ORG_MODE.equals(appConfig.getString(ConfigProperty.OWNERSHIP_TYPE))) {
            defaultOrganization = appConfig.getString(ConfigProperty.DEFAULT_ORGANIZATION);
        }

        Organization o = null;

        if (!defaultOrganization.isEmpty()) {
            o = userFacade.getOrganizationByName(defaultOrganization);
            if (o == null) {
                o = new Organization();
                o.setName(defaultOrganization);
                userFacade.save(o);
            }
            user.setOrganization(o);
        }

Solution: if (defaultOrganization != null && !defaultOrganization.isEmpty()) {

[peterklimo]

i will close open issues today after 22.00

On March 29, 2015 6:36:46 PM CEST, Tomas Knap [email protected] wrote:

@peterklimo One more issue, the following code (if (!defaultOrganization.isEmpty()) ) from
PasswordAuthenticationProvider.java throws NullPointerException if
ownership.type is set to user (in config properties) and organization
is not specified in config.properties:

 String defaultOrganization = null;
if
(ORG_MODE.equals(appConfig.getString(ConfigProperty.OWNERSHIP_TYPE))) {
defaultOrganization =
appConfig.getString(ConfigProperty.DEFAULT_ORGANIZATION);
       }

       Organization o = null;

       if (!defaultOrganization.isEmpty()) {
           o = userFacade.getOrganizationByName(defaultOrganization);
           if (o == null) {
               o = new Organization();
               o.setName(defaultOrganization);
               userFacade.save(o);
           }
           user.setOrganization(o);
       }

Solution: if (defaultOrganization != null &&
!defaultOrganization.isEmpty()) {

---

Reply to this email directly or view it on GitHub:
#282 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

[peterklimo]

fixed
update script created and pushed into repository

see e6820a0

On Sun, Mar 29, 2015 at 7:19 PM, Peter Klimo [email protected] wrote:

i will close open issues today after 22.00

On March 29, 2015 6:36:46 PM CEST, Tomas Knap [email protected]
wrote:

@peterklimo https://github.com/peterklimo One more issue, the
following code (if (!defaultOrganization.isEmpty()) ) from
PasswordAuthenticationProvider.java throws NullPointerException if
ownership.type is set to user (in config properties) and organization is
not specified in config.properties:

String defaultOrganization = null;
if (ORG_MODE.equals(appConfig.getString(ConfigProperty.OWNERSHIP_TYPE))) {
defaultOrganization = appConfig.getString(ConfigProperty.DEFAULT_ORGANIZATION);
}

    Organization o = null;

    if (!defaultOrganization.isEmpty()) {
        o = userFacade.getOrganizationByName(defaultOrganization);
        if (o == null) {
            o = new Organization();
            o.setName(defaultOrganization);
            userFacade.save(o);
        }
        user.setOrganization(o);
    }

Solution: if (defaultOrganization != null &&
!defaultOrganization.isEmpty()) {

—
Reply to this email directly or view it on GitHub
#282 (comment).

Sent from my Android device with K-9 Mail. Please excuse my brevity.