Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs should not be allowed to grow indefinitely #527

Closed
spinque opened this issue Sep 10, 2015 · 4 comments
Closed

Logs should not be allowed to grow indefinitely #527

spinque opened this issue Sep 10, 2015 · 4 comments

Comments

@spinque
Copy link

spinque commented Sep 10, 2015

Some DPUs can be very verbose. This combined with situations where many intermediate files are processed makes the log files grow quickly to tens of GB.
ODN is often deployed on VMs where large disk space is not expected to be necessary (certainly not for logs).
In this settings, it happens that pipelines fail because no space is left on device. Just making a DPU too talkative makes the whole system becomes vulnerable. This should never be allowed.

I suggest to make sure that log files can never grow larger than a (configurable) size. I would also suggest not to implement this as a scheduled log rotation mechanism, because that may be not sufficient (one single pipeline can already fill up the disk space before the log rotation comes in action)

@skrchnavy skrchnavy added this to the Release v2.3.0 milestone Sep 10, 2015
@tomas-knap tomas-knap self-assigned this Oct 1, 2015
@tomas-knap tomas-knap modified the milestones: Release v2.3.0, Release v2.4.0 Oct 13, 2015
@tomas-knap tomas-knap modified the milestones: Release v2.4.0, Release v2.3.0 Nov 2, 2015
@tomas-knap tomas-knap modified the milestones: Release v2.3.3, Release v2.3.2 Oct 13, 2016
@tomas-knap
Copy link

tomas-knap commented May 10, 2017

See for backend: d6ce758

@tomas-knap
Copy link

@tomas-knap
Copy link

Solved by introducing max log size for backend, frontend, master app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants