Bibliographies

[fredrik-bakke]

Adds citation support using a biblatex file and pybtex, reactors most current citations to use it, and adds a small guide to explain how to use it.

Resolves #957.

[fredrik-bakke]

This one's ready for review :) Please build the website locally to see how the new references look. Note that I have not written any documentation yet.

[fredrik-bakke]

I've resolved all but your comment regarding changing the HTML backend, which I will do tonight. In the process of reviewing this PR, I found a series of other mistakes in the citations and bibliography file too that are now fixed. @VojtechStep

EDIT: It's resolved now too

[VojtechStep]

Note that while disabling the check-ast pre-commit hook silences the CI, running the preprocessor still fails on Python 3.8, it's just at runtime and (for some reason) silent - the website build finishes, but the preprocessor never runs. We should reinstate the check-ast hook and make sure our scripts actually run on 3.8 @fredrik-bakke

[VojtechStep]

It seems that just removing the newlines introduced in f-strings solves this. It looks like this bug in autopep8 with Python 3.12: hhatto/autopep8#712

[fredrik-bakke]

Note that while disabling the check-ast pre-commit hook silences the CI, running the preprocessor still fails on Python 3.8, it's just at runtime and (for some reason) silent - the website build finishes, but the preprocessor never runs. We should reinstate the check-ast hook and make sure our scripts actually run on 3.8 @fredrik-bakke

Python amirite

[fredrik-bakke]

Thanks for catching this before a merge. Of course it didn't fail when I tested locally because I run a python version that is compatible with the formatting

[VojtechStep]

Looks great 👌; I think after the f-string are fixed this one is ready to be merged

[VojtechStep]

One last request - could you log which file included a dangling citation/reference? Adding chapter['path'] to the logged message should be enough.

[fredrik-bakke]

Anything else? 🤓

[VojtechStep]

Nope, that's everything I could have asked for. Thanks again for picking this up, and feel free to merge the PR, I already put my laptop away 🎉