Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests.yml: Refactor testing #791

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

unittests.yml: Refactor testing #791

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 11, 2024 •
edited
Loading

@cclauss cclauss force-pushed the patch-3 branch 3 times, most recently from 2cfc074 to 2c054d6 Compare November 11, 2024 20:03
@cclauss cclauss force-pushed the patch-3 branch 4 times, most recently from 99b1a09 to f13b6b6 Compare November 25, 2024 14:05
@cclauss cclauss mentioned this pull request Nov 25, 2024
Open
@cclauss cclauss force-pushed the patch-3 branch 5 times, most recently from e7eee66 to 4f92962 Compare December 9, 2024 16:11
ftnext
ftnext requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@ftnext ftnext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss This pull request tries to add macOS and refactor existing code at once.
Please separate the pull requests for each change.
I will review them after that.

Please cooperate to make it easier to review and merge.

@cclauss cclauss changed the title unittests.yml: Add macOS to the testing unittests.yml: Refactor testing Dec 10, 2024
@cclauss cclauss mentioned this pull request Dec 10, 2024
Open
@cclauss cclauss marked this pull request as draft December 10, 2024 06:59
@cclauss cclauss marked this pull request as ready for review December 18, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftnext ftnext ftnext requested changes

Assignees

@cclauss cclauss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @ftnext