Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request proposes a license change to the VIC source code. In 2014, leading up to the major refactor that became VIC-5, we added the GPL-2 license to the VIC source code (#133). I vaguely remember discussing the choice of license with @bartnijssen but we didn't have public discussion about the choice.
Now, seven years later, I'm proposing to change VIC's license to the more permissive MIT license. While I'm not an expert on the legal specifics here, my understanding (and goal) is that this change will relax constraints on usage and third-party development, and perhaps more importantly, makes it easier for folks to use VIC in environments that don't support GPL licensed dependencies.
As a concrete example to motivate this change, I would like to incorporate part of the VIC source code into a separate project I'm working on. That project uses the MIT license and depending on VIC's implementation, would require adopting the GPL-2 license there as well (a non-starter).
Further reading
https://choosealicense.com/licenses/mit/
https://opensource.guide/legal/
http://nipy.sourceforge.net/software/license/johns_bsd_pitch.html (discussion about a similar switch for Matplotlib)
closes #xxx
tests passed
new tests added
science test figures
ran uncrustify prior to final commit
ReleaseNotes entry