Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/nc close #774

Merged
merged 13 commits into from
Jan 31, 2018
Merged

Bugfix/nc close #774

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8675a06
Merge branch 'feature/routing_lohmann' of https://github.com/wietsefr…
bartnijssen Oct 20, 2017
b034636
Merge branch 'wietsefranssen-feature/routing_lohmann' into develop
bartnijssen Oct 20, 2017
67b1dff
Merge branch 'develop' of https://github.com/UW-Hydro/VIC into develop
bartnijssen Oct 20, 2017
b6a6b21
Merge pull request #9 from bartnijssen/develop
wietsefranssen Oct 23, 2017
8138db3
applied changes suggested by joe
wietsefranssen Oct 23, 2017
7458311
merge
wietsefranssen Oct 30, 2017
9270582
minor changes
wietsefranssen Oct 30, 2017
1d9d33b
Merge branch 'develop' of https://github.com/UW-Hydro/VIC into develop
wietsefranssen Jan 17, 2018
4ec3e4f
fixed little bug
wietsefranssen Jan 17, 2018
9329fc4
Merge branch 'develop' into bugfix/nc_close
Jan 19, 2018
cc03ff7
added a note
wietsefranssen Jan 22, 2018
5a4da41
Merge branch 'bugfix/nc_close' of github.com:wietsefranssen/VIC into …
wietsefranssen Jan 22, 2018
98d89b1
Merge branch 'develop' into bugfix/nc_close
bartnijssen Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/Development/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ To check which release of VIC you are running:

1. Renamed "fcov" to "fcan" in image driver to better match variable code name ([GH#673](https://github.com/UW-Hydro/VIC/pull/673))

1. NetCDF forcing files are now closed at the last timestep in stead of after the last timestep. ([GH#774](https://github.com/UW-Hydro/VIC/pull/774))

------------------------------

## VIC 5.0.1
Expand Down
4 changes: 2 additions & 2 deletions vic/drivers/image/src/vic_force.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ vic_force(void)

if (mpi_rank == VIC_MPI_ROOT) {
// Close forcing file if it is the last time step
if (current == global_param.nrecs) {
if (current == global_param.nrecs - 1) {
status = nc_close(filenames.forcing[0].nc_id);
check_nc_status(status, "Error closing %s",
filenames.forcing[0].nc_filename);
Expand Down Expand Up @@ -375,7 +375,7 @@ vic_force(void)

if (mpi_rank == VIC_MPI_ROOT) {
// Close forcing file if it is the last time step
if (current == global_param.nrecs) {
if (current == global_param.nrecs - 1) {
status = nc_close(filenames.forcing[1].nc_id);
check_nc_status(status, "Error closing %s",
filenames.forcing[1].nc_filename);
Expand Down