Feature/move max iter grnd canopy #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgergel
commented
Jan 16, 2018
dgergel
commented
- closes move MAX_ITER_GRND_CANOPY to parameters struct #770
- tests passed
- new tests added
- science test figures
- ran uncrustify prior to final commit
- ReleaseNotes entry
jhamman
requested changes
Jan 16, 2018
vic/vic_run/src/surface_fluxes.c
Outdated
| MAX_ITER_GRND_CANOPY = 0; | ||
| if (!options.CLOSE_ENERGY) { | ||
| // if not closing energy balance, don't iterate | ||
| param.MAX_ITER_GRND_CANOPY = 0; |
There was a problem hiding this comment.
can we move this change to the parameters initialization? No need to reset this variable each timestep.
There was a problem hiding this comment.
I considered doing that but moving it to vic/drivers/shared_all/src/initialize_parameters.c requires using the options struct in that routine, which we don't currently do - do you think that's fine?
There was a problem hiding this comment.
yes, I think that it probably cleanest.
There was a problem hiding this comment.
I've updated this as you suggested - I'll ping you once the tests pass and it's ready for another review.
… in shared_all from surface_fluxes.c in vic_run
…l/VIC into feature/move_max_iter_grnd_canopy
…l/VIC into feature/move_max_iter_grnd_canopy
|
@jhamman this is ready for another review. |
jhamman
approved these changes
Jan 26, 2018
jhamman
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.