fix evap units and sign #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgergel
commented
Aug 7, 2017
•
dgergel
commented
- closes fix units and sign for evap passed to coupler CESM driver #727
- tests passed
- new tests added
- science test figures
- ran uncrustify prior to final commit
- ReleaseNotes entry
|
Which #xxx is this closing (the point is to indicate which issue this PR is related to)? |
bartnijssen
reviewed
Aug 7, 2017
vic/drivers/cesm/src/cesm_put_data.c
Outdated
| @@ -159,9 +159,8 @@ vic_cesm_put_data() | |||
|
|
|||
| // evaporation, VIC: mm, CESM: kg m-2 s-1 | |||
| // TO-DO should we incorporate bare soil evap? | |||
There was a problem hiding this comment.
Is this TODO still relevant? My assumption is that WRF wants total evap, so if soil evap is already included in OUT_EVAP then we should be OK. If not, then we should add it.
There was a problem hiding this comment.
It's not still relevant. Since we're using evap from OUT_DATA here, it's already incorporating soil evap.
|
@bartnijssen I hadn't opened an issue. Will do that so that we can close it with this PR. |
…IC into feature/fix_evap_passed_to_wrf
jhamman
approved these changes
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.