Feature/fix latent heat and longwave coupler fields #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
Mar 3, 2017
| @@ -258,7 +258,7 @@ vic_cesm_put_data() | |||
|
|
|||
There was a problem hiding this comment.
Does VIC have different sign conventions for AtmosLatent and AtmosSensible?
There was a problem hiding this comment.
They are the same in ~/vic/vic/drivers/shared_all/src/put_data.c, but these sign conventions agree with those in VIC 4 in RASM (e.g. these make the coupler fields for VIC 5 in RASM agree with VIC 4 in RASM).
jhamman
approved these changes
Mar 7, 2017
docs/Development/ReleaseNotes.md
Outdated
| 1. Fix sign for latent heat fluxes passed from VIC to the coupler | ||
| 2. Fix sign for longwave radiation passed from VIC to the coupler | ||
|
|
||
| ([GH#696](https://github.com/UW-Hydro/VIC/pull/696)) |
There was a problem hiding this comment.
there was a merge conflict here that I corrected via github, this does't look quite right though. Can you check/fix this.
There was a problem hiding this comment.
Should be all fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes in the CESM driver: