Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to build for both intel and m1 chips for macos #70

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Update to build for both intel and m1 chips for macos #70

merged 5 commits into from
Dec 12, 2024

Conversation

cbuahin
Copy link
Collaborator

@cbuahin cbuahin commented Oct 21, 2024

No description provided.

@cbuahin cbuahin self-assigned this Oct 21, 2024
@cbuahin cbuahin mentioned this pull request Oct 21, 2024
Closed
@cbuahin cbuahin requested a review from ucchejbb October 21, 2024 19:26
@cbuahin
Copy link
Collaborator Author

cbuahin commented Oct 21, 2024

dbhart, @ucchejbb , mentioned you had a question about building to support both apple silicon and intel. This is my fix. I noticed you are trying to do the same on the msx side. I think we should adopt the same strategy for consistency. Let me know what you think.

@ucchejbb ucchejbb requested a review from woohn December 12, 2024 19:07
woohn
woohn approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@woohn woohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@woohn woohn merged commit 8cf3451 into master Dec 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woohn woohn woohn approved these changes

@ucchejbb ucchejbb Awaiting requested review from ucchejbb

Assignees

@cbuahin cbuahin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbuahin @woohn