-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pure_pursuit, pure_pursuit_visualiser, head_to_goal, localization launch files #142
Conversation
looks good to me, just check the launch files run without any errors |
…, the rest has issues in the node file on msgs import
removed unnecessary messages type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you have the pure_pursuit_visualizer functionality incorporated in to the pure pursuit node.
Then parameterise publishing the visualizer topics based a 'vis' parameter.
…m:UOA-FSAE/autonomous into AD2-25_27_41_42
Request of changes completed, all launch files are tested too, pls review again it should be ready to merge |
…ursuit visualisation functions are in the pure_pursuit node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now.
In future the controllers launch file should be combined. However, it's best to recombine back to nightly first to take stock of everyone'ss changes.
Description
Issue #
created launch folders in the relevant packages and launch files in those launch folders
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: