Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pure_pursuit, pure_pursuit_visualiser, head_to_goal, localization launch files #142

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

winola-whu
Copy link

Description

Issue #

created launch folders in the relevant packages and launch files in those launch folders

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@winola-whu winola-whu self-assigned this Nov 17, 2024
@Tanish29
Copy link

looks good to me, just check the launch files run without any errors

winola-whu and others added 2 commits November 20, 2024 23:14
…, the rest has issues in the node file on msgs import
removed unnecessary messages type.
Copy link
Contributor

@Zane-Larking Zane-Larking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have the pure_pursuit_visualizer functionality incorporated in to the pure pursuit node.
Then parameterise publishing the visualizer topics based a 'vis' parameter.

@winola-whu
Copy link
Author

Request of changes completed, all launch files are tested too, pls review again it should be ready to merge

…ursuit visualisation functions are in the pure_pursuit node
Copy link
Contributor

@Zane-Larking Zane-Larking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now.
In future the controllers launch file should be combined. However, it's best to recombine back to nightly first to take stock of everyone'ss changes.

@winola-whu winola-whu merged commit ac6486f into nightly Dec 5, 2024
@winola-whu winola-whu deleted the AD2-25_27_41_42 branch December 5, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants