Initial k8s_sandbox project
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion, adapting for new repo structure.
craigwalton-dsit
force-pushed
the
craig/migrate-project
branch
from
bab1030 to
4ef16ad
Compare
craigwalton-dsit
requested review from
tcatling and
jasongwartz-aisi
and removed request for
tcatling
pyproject.toml
Outdated
| name = "inspect-k8s-sandbox" | ||
| version = "0.1.0" | ||
| description = "A Kubernetes Sandbox Environment for Inspect" | ||
| authors = ["Craig <[email protected]>"] |
There was a problem hiding this comment.
Should we have a team address or something we can use here? Let me see what inspect does.
There was a problem hiding this comment.
Just a name, not an email - maybe let's do that instead? https://github.com/UKGovernmentBEIS/inspect_ai/blob/main/pyproject.toml#L86
There was a problem hiding this comment.
Good shout! I think poetry does name+email automatically, but UK AI Safety Institute makes much more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.toml(regenerated lockfile), removing unused deps like boto3src/k8s_sandbox(includes Helm chart)test/k8s_sandboxI don't expect anyone to read through the whole list of "files changed"! Please see individual commits to check my working.
Note: I intentionally committed the original
.pyfiles with their "broken" imports verbatim from our internal repo, and did a find/replace to fix them in a subsequent commit. This was to make reviewing my work easier and to help with traceability. This doesn't expose any other parts of our internal repo. It simply means that one can see thatk8s_sandboxused to live inside a parentaisitoolspackage.