PC-1464: Improve select your supplier question #411
Conversation
samyou-softwire
force-pushed
the
PC-1464-Improve-select-your-supplier-question
branch
2 times, most recently
from
0f450e8 to
479b9e5
Compare
|
noticed I've missed error texts, will push a fix |
samyou-softwire
force-pushed
the
PC-1464-Improve-select-your-supplier-question
branch
from
479b9e5 to
55db761
Compare
help_to_heat/frontdoor/interface.py
Outdated
| supplier = api.session.get_answer(self.session_id, supplier_page).get(supplier_field) | ||
| alternative_supplier = api.session.get_answer(self.session_id, alternative_supplier_page).get( | ||
| alternative_supplier_field | ||
| ) | ||
|
|
||
| return alternative_supplier if self._did_specify_alternative() else supplier |
There was a problem hiding this comment.
I don't think there's real overhead to api.session.get_answer is there? We could be quite a bit more efficient with how many times we're calling it if so.
There was a problem hiding this comment.
don't think so too much, though it is a database call. have reworked it to cache the result
help_to_heat/frontdoor/interface.py
Outdated
| session_data[supplier_field] = "Octopus Energy" | ||
| if self._is_utility_warehouse(): | ||
| session_data["supplier"] = "E.ON Next" | ||
| session_data[supplier_field] = "E.ON Next" |
There was a problem hiding this comment.
Should these be using constants?
| # where to send the user post them picking a supplier | ||
| def _post_supplier_pick_next_page(supplier): |
There was a problem hiding this comment.
Can this be named better so the comment isn't necessary?
There was a problem hiding this comment.
looking back I don't think the comment adds much anyway. have removed it & changed the name slightly
help_to_heat/frontdoor/consts.py
Outdated
| @@ -104,7 +108,7 @@ | |||
| supplier_field_shell = "Shell" | |||
| supplier_field_utilita = "Utilita" | |||
| supplier_field_utility_warehouse = "Utility Warehouse" | |||
| supplier_fields = [ | |||
| supplier_fields_real = [ | |||
There was a problem hiding this comment.
Can this be made to read a bit more naturally? Would quibble that these aren't fields, they're values
There was a problem hiding this comment.
for what its worth most of these fields could be named as such, ie supplier_field_utilitia -> supplier_field_value_utilita. for now have renamed the fields to field_values
samyou-softwire
force-pushed
the
PC-1464-Improve-select-your-supplier-question
branch
from
55db761 to
f5869e3
Compare
|
translations for "Select an alternative energy supplier" have been added |
when supplier is referenced, make a safe call that allows it to be overridden with the alternative if needed make the check answers page for supplier send to alternative supplier if needed overwrite supplier with alternative if necessary when generating referral
samyou-softwire
force-pushed
the
PC-1464-Improve-select-your-supplier-question
branch
from
f5869e3 to
dc6469a
Compare
|
@jdgage if there's nothing else & pipelines pass this should be ready to go |
samyou-softwire
deleted the
PC-1464-Improve-select-your-supplier-question
branch
Link to Jira ticket
Description
adds an alternative supplier page
if the user selects that they don't know they are sent here and can select any supplier
needs some extra work when displaying supplier name to ensure the correct supplier is always shown, as well as some additional work when submitting so energy suppliers see the alternative that was picked
Checklist
make extract-translationsScreenshots