Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC-519: CSV changes for service managers #249

Merged
merged 1 commit into from
Dec 1, 2023
Merged

PC-519: CSV changes for service managers #249

merged 1 commit into from
Dec 1, 2023

Conversation

chidin194
Copy link
Contributor

Additions to the CSV requested by DESNZ, in particular:

  • Country
  • Postcode
  • EPC letter rating (in the case where we don't find a rating, I've kept the original logic intact, so we will still populate "", instead of "Not found" - hopefully this is fine

What the CSV looks like now locally for me:
image

LadunOmideyiSoftwire
LadunOmideyiSoftwire approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@LadunOmideyiSoftwire LadunOmideyiSoftwire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And yes, that's the correct way to handle no EPC being found.

@chidin194 chidin194 merged commit d39b6ef into develop Dec 1, 2023
3 checks passed
@jamiehumphries jamiehumphries deleted the pc-519-add-country-epc-to-csv branch January 19, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadunOmideyiSoftwire LadunOmideyiSoftwire LadunOmideyiSoftwire approved these changes

@CheshireSwift CheshireSwift CheshireSwift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chidin194 @CheshireSwift @LadunOmideyiSoftwire