PC-505: Add new GBIS feedback questions

[chidin194]

New GBIS feedback form, pending Welsh translations from DESNZ

[chidin194]

From a design perspective, is this error enough? I was also considering adding a red margin to each question, but that might be confusing since none are specifically mandatory:

[AyaPK]

A few things to look at but mostly looks good!

[AyaPK]

Regarding the error message

From a design perspective, is this error enough? I was also considering adding a red margin to each question, but that might be confusing since none are specifically mandatory:

I'd say to look at the component style guidelines, and actually use an error summary component for this
https://design-system.service.gov.uk/components/error-summary/

[chidin194]

Regarding the error message

From a design perspective, is this error enough? I was also considering adding a red margin to each question, but that might be confusing since none are specifically mandatory:

I'd say to look at the component style guidelines, and actually use an error summary component for this https://design-system.service.gov.uk/components/error-summary/

So I've used the error summary class, but this way of validating a form doesn't fit in with the usual validation pattern on the design system as we're not validating any one specific field in particular. Also, adding a separate error message alongside each field might require more extensive changes since we get the data in a blob. Maybe this needs a separate conversation with the client! @AyaPK @CheshireSwift

[AyaPK]

So I've used the error summary class, but this way of validating a form doesn't fit in with the usual validation pattern on the design system as we're not validating any one specific field in particular. Also, adding a separate error message alongside each field might require more extensive changes since we get the data in a blob. Maybe this needs a separate conversation with the client! @AyaPK @CheshireSwift

I'd posit you could just do something like:

<div class="govuk-error-summary" data-module="govuk-error-summary">
  <div role="alert">
    <h2 class="govuk-error-summary__title">
      There was a problem submitting the form
    </h2>
    <div class="govuk-error-summary__body">
      <ul class="govuk-list govuk-error-summary__list">
        <li>
          <a href="#">Please answer at least one question before submitting feedback</a>
        </li>
      </ul>
    </div>
  </div>
</div>

which would look much nicer, fitting the style guidelines and using the component as intended

[chidin194]

New and improved error screen:

[CheshireSwift]

Couple of things, but mostly good.