Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves performance issue by removing invalid config #768

Closed
wants to merge 1 commit into from
Closed

Resolves performance issue by removing invalid config #768

wants to merge 1 commit into from

Conversation

garethflowers
Copy link

Setting files and includes to empty arrays creates an invalid tsconfig.json file - and seems to subsequently cause performance issues.

This PR will remove the properties altogether.

Fixes #754.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 86.216% when pulling 07bdb16 on garethflowers:master into 544851e on TypeStrong:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 86.216% when pulling 07bdb16 on garethflowers:master into 544851e on TypeStrong:master.

@blakeembrey
Copy link
Member

@garethflowers I'll take a look. My concern with deleting the files means that TypeScript actually resolves every file in the directory, breaking what this was originally added to solve.

@blakeembrey
Copy link
Member

blakeembrey commented Jan 26, 2019

Confirmed, it breaks file loading and fixes perf by preloading every file in the current directory. I can't accept this PR as-is. We should try to find the root cause here.

@blakeembrey
Copy link
Member

I just noticed this did not work correctly with include, typo'd as includes. I'll release a version with this but if it is related to files I'm not sure this will fix things for you. Best course of action would be finding a project large enough I can replicate the issues on.

@blakeembrey
Copy link
Member

I don't think it's e009d79, but please try it out and let me know if the latest patch improves things!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants