[WIP] A way to add kwarg support to #164 #165
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a branch locally with some initial work on kwarg-support, and now, thanks to #164, it works!
A few very important drawbacks:
Core.kwftype
.cache
anddeepcopy_types
that are used in Libtask.jl. This can be resolved by a) renaming those to something less common, e.g.__libtask__cache__
or something, and b) throwing an error if we hit it.EDIT: I wanted to make this PR to your branch @willtebbutt but couldn't because that branch is on your fork.