-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace instances of @submodel
with to_submodel()
#751
Open
penelopeysm
wants to merge
6
commits into
master
Choose a base branch
from
py/cleanup-submodel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
py/cleanup-submodel
branch
from
December 13, 2024 17:35
6453303
to
6567e2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
==========================================
- Coverage 85.94% 85.93% -0.02%
==========================================
Files 36 36
Lines 4276 4280 +4
==========================================
+ Hits 3675 3678 +3
- Misses 601 602 +1 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12323480116Details
💛 - Coveralls |
penelopeysm
force-pushed
the
py/cleanup-submodel
branch
from
December 13, 2024 19:51
9e75ada
to
2b64e65
Compare
penelopeysm
force-pushed
the
py/cleanup-submodel
branch
from
December 13, 2024 21:39
a987195
to
490a992
Compare
penelopeysm
force-pushed
the
py/cleanup-submodel
branch
from
December 13, 2024 21:42
490a992
to
515bf18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces remaining instances of
@submodel
withto_submodel
in DynamicPPL, including in the demo models.To get tests to pass, it also implements the functionality needed for the
pointwise_logp
family of functions to work on submodels.To prevent
@submodel
from being completely untested, It also adds some very basic tests for@submodel
insidetest/deprecated.jl
, just to make sure that it's still behaving correctly.Closes #750
Closes #752