Why use node-pre-gyp instead of node-gyp?
#1714
Labels
Comments
|
What's wrong with the BSD license? This repository uses the BSD license as well. |
|
The problem shouldn't be the license, but that |
|
@fcanela Totally agree. 3 days still looking for a workaround |
daniellockyer
added a commit
that referenced
this issue
Dec 24, 2023
…stall` fixes #1641 fixes #1721 fixes #1714 fixes #1713 fixes #1700 fixes #1704 - `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs which our users keep running into - it seems the prebuilt binary world has moved in favor of prebuild + it's various other forms - one option would be to use prebuildify to bundle all binaries into the package, but that's a step too far removed from the current situation for now - instead, we can use prebuild-install to download the binaries, and `prebuild` to build + upload the binaries - this means we can remove node-pre-gyp and fix a bunch of issues! [1]: mapbox/node-pre-gyp#657
daniellockyer
added a commit
that referenced
this issue
Dec 24, 2023
…stall` fixes #1641 fixes #1721 fixes #1714 fixes #1713 fixes #1700 fixes #1704 - `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs which our users keep running into - it seems the prebuilt binary world has moved in favor of prebuild + it's various other forms - one option would be to use prebuildify to bundle all binaries into the package, but that's a step too far removed from the current situation for now - instead, we can use prebuild-install to download the binaries, and `prebuild` to build + upload the binaries - this means we can remove node-pre-gyp and fix a bunch of issues! - eventually, we could start providing electron prebuilt binaries too [1]: mapbox/node-pre-gyp#657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Why use
node-pre-gypinstead ofnode-gyp? Thenode-pre-gypuses the BSD license.Proposed implementation
We need to carefully consider products under the BSD license.
The text was updated successfully, but these errors were encountered: