-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added option to disable free signups #21862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
migration
[pull request] Includes migration for review
label
Dec 11, 2024
sagzy
force-pushed
the
add-disable-free-signups-option
branch
3 times, most recently
from
December 16, 2024 05:47
bf428d0
to
d0e2d8e
Compare
sagzy
changed the title
Added paid option to members_signup_access setting
✨ Added an option to disable free signups
Dec 16, 2024
sagzy
changed the title
✨ Added an option to disable free signups
✨ Added option to disable free signups
Dec 16, 2024
sagzy
force-pushed
the
add-disable-free-signups-option
branch
from
December 19, 2024 09:51
3eac217
to
adbf5e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/ENG-1235
problem: today, when a publisher removes the "free" tier from the Portal settings, it doesn't disable free signups entirely. It removes the free tier from the Portal UI, but free signup is still possible via other avenues (signup form in themes, embeddable signup form on another site, direct API call). This creates confusion/frustration for publishers who thought they disabled free signups, but are still getting unwanted free signups (spam). There is no way to disable free signups entirely.
solution: introduced a new "paid-members only" subscription access setting, which blocks all free signups at the API level. If chosen, the free tier is hidden in Portal and all free signup are blocked at the API level with a readable error message (
This site only accepts paid members.
)