Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added option to disable free signups #21862

Merged
merged 32 commits into from
Dec 19, 2024
Merged

Conversation

sagzy
Copy link
Contributor

@sagzy sagzy commented Dec 11, 2024

ref https://linear.app/ghost/issue/ENG-1235

  • problem: today, when a publisher removes the "free" tier from the Portal settings, it doesn't disable free signups entirely. It removes the free tier from the Portal UI, but free signup is still possible via other avenues (signup form in themes, embeddable signup form on another site, direct API call). This creates confusion/frustration for publishers who thought they disabled free signups, but are still getting unwanted free signups (spam). There is no way to disable free signups entirely.

  • solution: introduced a new "paid-members only" subscription access setting, which blocks all free signups at the API level. If chosen, the free tier is hidden in Portal and all free signup are blocked at the API level with a readable error message (This site only accepts paid members.)

CleanShot 2024-12-10 at 09 09 28@2x

@github-actions github-actions bot added the migration [pull request] Includes migration for review label Dec 11, 2024
@sagzy sagzy removed the migration [pull request] Includes migration for review label Dec 12, 2024
@TryGhost TryGhost deleted a comment from github-actions bot Dec 12, 2024
@sagzy sagzy force-pushed the add-disable-free-signups-option branch 3 times, most recently from bf428d0 to d0e2d8e Compare December 16, 2024 05:47
@sagzy sagzy changed the title Added paid option to members_signup_access setting ✨ Added an option to disable free signups Dec 16, 2024
@sagzy sagzy changed the title ✨ Added an option to disable free signups ✨ Added option to disable free signups Dec 16, 2024
@sagzy sagzy force-pushed the add-disable-free-signups-option branch from 3eac217 to adbf5e7 Compare December 19, 2024 09:51
@sagzy sagzy marked this pull request as ready for review December 19, 2024 09:52
@sagzy sagzy merged commit e67e241 into main Dec 19, 2024
21 checks passed
@sagzy sagzy deleted the add-disable-free-signups-option branch December 19, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant