Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signup-form.json #21831

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update signup-form.json #21831

merged 1 commit into from
Dec 12, 2024

Conversation

alexrodba
Copy link
Contributor

Corrected typos and style. Added missing translations. Added coherent style (tu vs vostè) across files.

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

@cathysarisky
Copy link
Contributor

Hi @alexrodba , thank you for these contributions. As I understand it, you're changing the formality of these translations, is that correct? From formal to informal? We've gone with informal (at least mostly) for languages with two formality levels, so that seems appropriate to me.

@alexrodba
Copy link
Contributor Author

Hi @alexrodba , thank you for these contributions. As I understand it, you're changing the formality of these translations, is that correct? From formal to informal? We've gone with informal (at least mostly) for languages with two formality levels, so that seems appropriate to me.

Yes. Informal is the norm nowadays as even newspapers and government sites use it. Thanks for checking, though!

Corrected typos and style. Added missing translations. Added coherent style (tu vs vostè) across files.
@ErisDS ErisDS enabled auto-merge (squash) December 12, 2024 14:14
@ErisDS ErisDS merged commit b1275e6 into TryGhost:main Dec 12, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants