Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments.json #21827

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Update comments.json #21827

merged 2 commits into from
Dec 12, 2024

Conversation

alexrodba
Copy link
Contributor

@alexrodba alexrodba commented Dec 8, 2024

Corrected certain inaccuracies. Added coherence to infinitives for actions (save -> desar) and added blank translations.

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on these - just a few questions!

"This comment has been removed.": "Aquest comantari s'ha esborrat.",
"Upgrade now": "Millora ara",
"Upgrade now": "Actualitzar ara",
"Yesterday": "Ahir",
"Your request will be sent to the owner of this site.": "La vostra sol·licitud s'enviarà al propietari d'aquest lloc."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vostra is inconsistent with the informal language used elsewhere, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I somehow missed this one. Should be changed to "teva". Thanks for spotting it!

"Show 1 more reply": "Mostrar 1 resposta més",
"Show 1 previous comment": "Mostrar 1 comentari previ",
"Show comment": "Mostrar comentari",
"Sign in": "Iniciar sessió",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another question about imperative vs infinitive, if you could please confirm. Context: These are a labels for a link or a button.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change them to imperative as per Softcatala's instructions: https://www.softcatala.org/forum/viewtopic.php?f=4&t=269 although Imperative might be preferred for certain generic actions like seach or sign in. We will keep imperative for specific actions like "show 1 more reply".

"Discussion": "Debat",
"Edit": "Editar",
"Edit this comment": "Editar aquest comentari",
"edited": "editat",
"Enter your name": "Escriu el teu nom",
"Expertise": "Conéixement",
"Expertise": "Expertesa",
"Founder @ Acme Inc": "Fundador @ Acme Inc",
"Full-time parent": "Pare a temps complert",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your change, but should it be complet or complert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complet!

"This comment has been hidden.": "Aquest comentari s'ha amagat.",
"Sort by": "Ordenar per",
"Start the conversation": "Començar la conversa",
"This comment has been hidden.": "Aquest comentari s'ha ocultat.",
"This comment has been removed.": "Aquest comantari s'ha esborrat.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not your change but this comantari (instead of comentari) hurts my eyes 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! let me fix it!

Copy link
Contributor Author

@alexrodba alexrodba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added changes following suggestions

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your work!

Corrected certain inaccuracies. Added coherence to infinitives for actions (save -> desar) and added blank translations.
Reviewed infinitive vs imperative considerations + 2 other fixes
@ErisDS ErisDS merged commit 904a300 into TryGhost:main Dec 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants