Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Updated Vietnamese translation #21230

Merged
merged 8 commits into from
Oct 7, 2024
Merged

🌐 Updated Vietnamese translation #21230

merged 8 commits into from
Oct 7, 2024

Conversation

mastoduy
Copy link
Contributor

@mastoduy mastoduy commented Oct 5, 2024

Re-translated the correct words in Vietnamese and adapted new commits.
Like: Improved i18n support for Portal error messages (#21190)

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Vietnamese, "Thẻ" is "Tag" and we should use Thẻ instead of "Thẻ Tag" (duplicate word)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey friend, I think all your translation improvements are fantastic! Thank you for your contributions.

Regarding "Tag": I specifically meant "Thẻ Tag" for my purposes. While "Thẻ" is correct, it feels too generic and may not resonate with SEO bloggers, leading to some confusion. Similarly, "Card" translates to "Thẻ," and "Tag" also translates to "Thẻ."

For instance, in YouTube's documentation, they translate "Tag" as "Thẻ từ khóa" in Vietnamese (Vietnamese source and English source). They aimed to convert a generic term into a more specific one for better user understanding.

One more thing: the Ghost admin interface doesn’t translate or support i18n. Admin users are also familiar with "Tag," so I tried to translate it to the more familiar term "Thẻ Tag" for Ghost users.

Similar to certain glossary terms like "online," "email," and "offline," if a generic word cannot be fully translated for better understanding, I suggest keeping "Tag" as is. All Vietnamese users are familiar with it since it’s commonly used in e-commerce, WordPress, and SEO contexts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think from a blogger's perspective, we all use Ghost CMS' Tags as "Categories". So what do you think? It would be pretty easy for blog readers to "Search for Author, Category, & Posts" ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, 100% agree, ghost Tags is Categories, easy understand for all Vietnamese readers. "Search for Author, Category, & Posts". Great idea :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Vietnamese, "email" is more accurate than "inbox"

@cathysarisky
Copy link
Contributor

I have very little to add here, except to say that I'm glad to see a discussion about translations happening! Thank you both for your work to make the 'vi' translations complete and better. Feel free to tag me when the discussion is complete and you're both ok with what's here, so I can make sure it gets into the queue. :)

Copy link
Contributor Author

@mastoduy mastoduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited it! Now you can merge this PR. Thank you @cathysarisky & @cuongtqtran <3

@cuongtqtran
Copy link
Contributor

cuongtqtran commented Oct 6, 2024

I have very little to add here, except to say that I'm glad to see a discussion about translations happening! Thank you both for your work to make the 'vi' translations complete and better. Feel free to tag me when the discussion is complete and you're both ok with what's here, so I can make sure it gets into the queue. :)

Thank you for your kind words! I want to express my gratitude for your {{content_api_key}} helper — it’s incredibly helpful for theme developers. I updated my theme immediately, and it works great!

@sagzy
Copy link
Contributor

sagzy commented Oct 7, 2024

Thanks @mastoduy and @cuongtqtran for the contribution 🎉

Following @cathysarisky's review, I'll go ahead and merge it

@sagzy sagzy merged commit 4288232 into TryGhost:main Oct 7, 2024
43 checks passed
tilak999 pushed a commit to tilak999/ghost that referenced this pull request Nov 20, 2024
no issue

- improved Vietnamese translations
- improved i18n support for Portal error messages
(cf. TryGhost#21190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants