Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Added staff notification when a sub is canceled due to failed payments #20534

Merged
merged 9 commits into from
Jul 15, 2024

Conversation

sagzy
Copy link
Contributor

@sagzy sagzy commented Jul 3, 2024

ref https://linear.app/tryghost/issue/ENG-1254

  • when a subscription is canceled automatically by Stripe (e.g. due to multiple failed payments), we now send a staff notification
  • logic before: if a member cancels a sub in Portal, then send a staff notification
  • logic now: if a subscription was active, but is now set to cancel immediately or at the end of the billing period, then send a staff notification.
  • with that logic change, we now send a cancellation staff notification when:
    1. A member cancels their sub in Portal (existing)
    2. A staff member cancels a member sub in Stripe (new)
    3. A staff member cancels a member sub in Admin (new)
    4. A sub is canceled automatically by Stripe because of multiple failed payments (new)
  • the copy of the staff notification email has also been updated to take into account 1) manual vs automatic cancellations, and 2) immediate vs end of billing period cancellations

sagzy added 4 commits July 4, 2024 11:18
fixes https://linear.app/tryghost/issue/ENG-1254

- when a subscription is canceled automatically by Stripe (e.g. due to multiple failed payments), send a staff notification
- so far, we were sending a cancellation staff notification only when a subscription was canceled manually by a member in Portal
@sagzy sagzy force-pushed the staff-email-for-failed-payment-cancellations branch from 1a75246 to 8228a5b Compare July 4, 2024 09:18
@sagzy
Copy link
Contributor Author

sagzy commented Jul 4, 2024

Pending copy changes on the email notification (discussion with Peter here)

@sagzy sagzy marked this pull request as ready for review July 4, 2024 09:20
@sagzy sagzy merged commit e476eeb into main Jul 15, 2024
22 checks passed
@sagzy sagzy deleted the staff-email-for-failed-payment-cancellations branch July 15, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant