Refactor SimpleStatement class in knowledge_data_access_layer.py #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
kozlovsky
and removed request for
a team
kozlovsky
approved these changes
Jan 18, 2024
The SimpleStatement class in knowledge_data_access_layer.py has been refactored to change the order of attributes. The attribute "predicate" is now placed before "object". This change improves readability and consistency within the codebase.
drew2a
force-pushed
the
refactoring/simple_statement
branch
from
a5d2f8d to
98aa2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing the follow-up for KnowledgeCommunity in #6214, I realized that the order of attributes in the
SimpleStatementcould be changed to appear more natural, following the (subject, predicate, object) notation.Ref: