-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add local search for tags #6617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
feature/click_on_tag
branch
3 times, most recently
from
December 3, 2021 15:38
bd0e90e
to
7e19225
Compare
drew2a
requested review from
a team and
kozlovsky
and removed request for
a team
December 6, 2021 13:48
kozlovsky
suggested changes
Dec 8, 2021
src/tribler-core/tribler_core/components/tag/restapi/tags_endpoint.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_validator.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/community/tag_validator.py
Outdated
Show resolved
Hide resolved
src/tribler-core/tribler_core/components/tag/restapi/tags_endpoint.py
Outdated
Show resolved
Hide resolved
drew2a
force-pushed
the
feature/click_on_tag
branch
4 times, most recently
from
December 9, 2021 19:19
139b62d
to
3c99810
Compare
drew2a
force-pushed
the
feature/click_on_tag
branch
6 times, most recently
from
December 14, 2021 12:41
43e2436
to
9c17de2
Compare
kozlovsky
suggested changes
Dec 15, 2021
kozlovsky
previously approved these changes
Dec 16, 2021
@kozlovsky thank you for the review! |
drew2a
force-pushed
the
feature/click_on_tag
branch
from
December 16, 2021 18:56
932db15
to
c65dc6e
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced search by tags. It partially solves #6551
Search by tags extends the current search endpoint by adding the tags keyword.
Tags within the search query should start from the
#
character.As a side-effect, this PR fixes #6612