Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add local search for tags #6617

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Dec 2, 2021

This PR introduced search by tags. It partially solves #6551

image

Search by tags extends the current search endpoint by adding the tags keyword.
Tags within the search query should start from the # character.

As a side-effect, this PR fixes #6612

@drew2a drew2a force-pushed the feature/click_on_tag branch 3 times, most recently from bd0e90e to 7e19225 Compare December 3, 2021 15:38
@drew2a drew2a changed the title Feature/click on tag Feature/add local search for tags Dec 3, 2021
@drew2a drew2a marked this pull request as ready for review December 6, 2021 13:48
@drew2a drew2a requested review from a team and kozlovsky and removed request for a team December 6, 2021 13:48
src/tribler-gui/tribler_gui/tribler_window.py Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/utilities.py Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/utilities.py Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/utilities.py Outdated Show resolved Hide resolved
src/tribler-common/tribler_common/utilities.py Outdated Show resolved Hide resolved
@drew2a drew2a force-pushed the feature/click_on_tag branch 4 times, most recently from 139b62d to 3c99810 Compare December 9, 2021 19:19
@drew2a drew2a marked this pull request as draft December 11, 2021 16:51
@drew2a drew2a force-pushed the feature/click_on_tag branch 6 times, most recently from 43e2436 to 9c17de2 Compare December 14, 2021 12:41
@drew2a drew2a marked this pull request as ready for review December 14, 2021 16:55
@drew2a drew2a requested a review from kozlovsky December 14, 2021 16:55
@drew2a drew2a requested a review from kozlovsky December 16, 2021 11:37
kozlovsky
kozlovsky previously approved these changes Dec 16, 2021
@drew2a
Copy link
Contributor Author

drew2a commented Dec 16, 2021

@kozlovsky thank you for the review!

@drew2a drew2a force-pushed the feature/click_on_tag branch from 932db15 to c65dc6e Compare December 16, 2021 18:56
@drew2a drew2a merged commit 25697fc into Tribler:main Dec 16, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"Filter parameter missing" error in case of "[]" query
2 participants