Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove homepage from the GUI and fix the discovery screen #5181

Merged
merged 5 commits into from
Mar 6, 2020

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Mar 5, 2020

Also, disable Credit Mining by default, and properly hide its icon if it is disabled.
Also, use emojis for Channels and Folders indication.
Also, fix personal channel options displayed in wrong situationl.

@ichorid ichorid added this to the V7.5: core refactoring milestone Mar 5, 2020
@ghost
Copy link

ghost commented Mar 5, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.408 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@ichorid ichorid force-pushed the f_remove_homepage branch from 78ae112 to 2742c3a Compare March 5, 2020 13:59
@ichorid ichorid marked this pull request as ready for review March 5, 2020 14:16
@ichorid ichorid requested a review from devos50 March 5, 2020 14:16
@ichorid ichorid force-pushed the f_remove_homepage branch from c07d97c to b07a536 Compare March 5, 2020 14:35
qstokkink
qstokkink previously approved these changes Mar 5, 2020
Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, fixes #5015?

@ichorid
Copy link
Contributor Author

ichorid commented Mar 5, 2020

Seems fine, fixes #5015?

No, still does not truly fix it. It just removes the current starting screen. Tribler starts much faster now if you have a big database, as there is no costly query for random torrents.

#5015 should still be properly addressed later, some time after 7.5 I guess.

@sonarcloud
Copy link

sonarcloud bot commented Mar 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ichorid ichorid merged commit 608be60 into Tribler:devel Mar 6, 2020
@ichorid ichorid deleted the f_remove_homepage branch March 6, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants