Live edges #2979
Live edges #2979
Conversation
qstokkink
force-pushed
the
live_edges
branch
14 times, most recently
from
89c82b0 to
f288303
Compare
qstokkink
force-pushed
the
live_edges
branch
5 times, most recently
from
bf68a66 to
acd9db5
Compare
|
@devos50 Do we want an on/off switch for this? |
|
@qstokkink this would be nice as a config option indeed 👍 |
|
@qstokkink also, want me to review this? |
|
@devos50 I have yet to add the config option, but if you have some spare time: yes, please 👍 |
qstokkink
force-pushed
the
live_edges
branch
2 times, most recently
from
49112bc to
c09af3d
Compare
| TestTriblerChainCommunity.create_block(other, node, self._create_target(other, node), transaction) | ||
|
|
||
| # Get statistics | ||
| node_trust = blockingCallFromThread(reactor, node.community.get_trust, other.community.my_member) |
There was a problem hiding this comment.
Why not simply decorate this whole method with an @blockingcallonreactorthread (and use yield self.create_nodes(2))?
| if block: | ||
| return block.sequence_number | ||
| else: | ||
| return 1 |
There was a problem hiding this comment.
Please comment that this is here so there is at least some chance a node will be visited.
| candidate.walk_response(time.time()) | ||
|
|
||
| # Assert | ||
| intro = blockingCallFromThread(reactor, node.community.dispersy_get_introduce_candidate, |
There was a problem hiding this comment.
See my previous comment about @blockingcallonreactorthread
| # Arrange | ||
| node, = self.create_nodes(1) | ||
|
|
||
| called = [False] |
There was a problem hiding this comment.
You can set attributes on callables so you could simply do something like:
def check_live_edge(...):
...
check_live_edge.called = True
check_live_edge.called = False
| node.community.take_step() | ||
|
|
||
| # Assert | ||
| self.assertTrue(called) |
There was a problem hiding this comment.
This is not valid I think, called will always be true, regardless whether called[0] is true or false.
|
|
||
| # Create a cache, so our introduction response is expected by the node | ||
| cache = object.__new__(IntroductionRequestCache) | ||
| blockingCallFromThread(reactor, IntroductionRequestCache.__init__, cache, |
There was a problem hiding this comment.
Again, see my comment about the @blockingcallfromreactorthread.
| blockingCallFromThread(reactor, node.community.on_introduction_response, [response]) | ||
|
|
||
| # Assert | ||
| self.assertTrue(called[0]) |
There was a problem hiding this comment.
See my previous comment about setting callables on attributes.
| def get_trust(self, member): | ||
| """ | ||
| Get the trust for another member. | ||
| Currently this is just the amount of MBs downloaded from them. |
There was a problem hiding this comment.
No only the MBs downloaded from them, also the MBs uploaded to them right?
|
|
||
| total_trust = sum([self.get_trust(candidate.get_member()) for candidate in eligible]) | ||
|
|
||
| random_trust_i = randint(0, total_trust - 1) |
There was a problem hiding this comment.
Please add some comment above this piece of code to explain how the candidate selection works.
| def on_introduction_response(self, messages): | ||
| super(TrustChainCommunity, self).on_introduction_response(messages) | ||
|
|
||
| if self._live_edges_enabled: |
There was a problem hiding this comment.
I would just return when self._live_edges_enabled is false.
This PR implements live edges for the MultiChain community as discussed in #2894 and #2458 .
Extra functionality:
MultiChainCommunity.cleanup_pending()to be aTaskManagertask, so that it gets destroyed when the community is unloaded.