chore(deps): support node v18 #526
Conversation
|
I know why the pipeline fails: #173 We need to find the proper way of accepting PRs from forks. |
muratcorlu
changed the title
|
As far as I see, storybook v6 doesn’t support node v18 without disabling new openssl provider which is not a great solution. I think we should consider fixing this together with #522 |
I upgraded to Storybook v7 and fixed couple of existing problems, but there are things to re-organize it seems - I need your help at this point. |
|
Yeah, I think upgrading to v7 will need a bigger re-organization of our storybook files. Let's connect on that. |
I think it's just the layout, shouldn't be a really big reorganization. I'd recommend reviewing current branch locally. After fixing the layout, I think this branch is ready to go live. |
|
With MDX2, they deprecated writing inline stories in MDX file. But maybe we can keep them for while if it works. I'll have a look at the branch. |
|
I decided to separate tasks by first fixing storybook upgrade (which already works well with both Node 16 and 18) then returning back to node 18 issue. Let's first merge #540 and return back to this. @AykutSarac PS: Once we got everything running in node 18 on local, we also need to check our pipeline config, because some of our jobs are forced to use node v16 now. |
|
@muratcorlu what do you think about replacing npm with yarn in this PR? |
What is the advantage of using yarn for us? |
|
🎉 This PR is included in version 2.1.0-beta.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
It worked fine on my end but I recommend testing locally.
Closes #361